Bonding, Porcelain Veneer or Crown for Tetracycline Stained Teeth? (Photos)

David- I'm sure you've received all the pros and cons you need to make the decision for yourself. While there is artistry involved in dentistry,  the materials used for crowns and veneers is mostly the same, ceramic. A more opaque ceramic blocks out the tooth color behind the crown or veneer but looks less natural. The coverage of the tooth varies, veneering covers a minimum and crowns cover all of the tooth will effect the overall look. Bonding is the least permanent fix but the results will be much less effective.
If you can't come to a decision, perhaps the decision is to wait until you are comfortable with the idea that your teeth will need to be cut back to cover the intrinsic staining. As an alternative, invest in sequential treatment instead of all 18 teeth treated at the same time.
Good luck!
Dr Ebner 

Hi:In your case the color will come through the bonding, so this is not a treatment of choice.  My preference is to do emax veneers on the top teeth and bottom front teeth and crown on lower back teeth so as to conserve as much tooth structure as possible.  Make sure this work is done by a experienced cosmetic dentist that works with a master technician so that work looks aesthetic and natural.

Your dentist is correct in recommending crowns over. I ding or veneers.  There is one simple reason to choose crowns- blocking out the underlying discoloration.  Bonding and veneers do not block out the discoloration which means that the tetracycline color will always shine through and affect the desired color.  Certain crowns have the ability to completely block out the discoloration and allow for a new shade to be present that is unaltered by stain. 

Is that your normal bite or are you protruding your jaw forward?   It would be best to have your underbite corrected(if that is your correct bite)  prior to proceeding with any type of restoration.   Your lower teeth protrude  and they made protrude  even further if orthodontics is not done first and your teeth are not prepared sufficiently.  At your current bite,  your upper teeth must be prepared properly so that they will not interfere with your lower teeth when you bite down. Without orthodontics, your restorations will be susceptible to premature breakage if your bite is not correct.  
 All that being said, if your bite were correct, I would  recommend 3/4 crowns instead of porcelain veneers or full crowns for tetracycline stained teeth such as yours.