I want porcelain veneers on top and bottom teeth. What to do about my teeth? (Photos)

I would recommend aligning the teeth and then consider whitening and then  consider minor cosmetic fillings and shaping of your teeth to get the desired cosmetic result. You could align the teeth with Invisalign if you don't want traditional braces .  This can work very well.
I would only advise you consider veneers on what look like health  unfilled teeth as you last and most invasive option.
Consider the long term implications carefully before you commit. 
Some veneers are no prep in other words the tooth is not touched and the veneers is bonded on the tooth - this has a disadvantage of having a small step where the veneer margin fits on the tooth. It may also make your teeth “stick out “a little more so it has to be carefully assess  beforehand. 
Traditional veneers involve removing some  of your  tooth enamel.  
 The disadvantages of veneers is that the process while theoretically reversible with no prep veneers and  is definitely  irreversible  with traditional prep veneers  . As one gets older there is normally some recession so that the veneers would likely need replacing at some point.  This is costly and involves again  touching and  adjusting your tooth tissue again .Furthermore there can be complications with any procedure including veneers - they can chip or  come off (debond),  and the tooth that has been prepared and  has had some its enamel removed  has a greater chance of requiring a root filling in the long term than an unprepared tooth. 

Thank you for sending your question and pictures. It would be ideal first to have invisalign to correct the alignments of your teeth, then to consider for placement of porcelain veneers. I am confident your final results will look spectacular. Feel free to come in for a private complimentary consultation to discuss the details of the treatment at one of my locations. All the best.